Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

regression test for Cow<[u8]> layout #145411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into rust-lang:master from the8472:cows-have-no-branches
Sep 22, 2025

Conversation

Copy link
Member

@the8472 the8472 commented Aug 14, 2025

requested by ralf in #117763 (comment)

TheElectronWill reacted with thumbs up emoji joshtriplett reacted with heart emoji
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2025
@the8472 the8472 changed the title (削除) regression test (削除ここまで) (追記) regression test for Cow<[u8]> layout (追記ここまで) Aug 14, 2025
Copy link
Member

@bors r+

Copy link
Collaborator

bors commented Aug 21, 2025

📌 Commit 919d413 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 21, 2025 
...ark-Simulacrum
regression test for Cow<[u8]> layout
requested by ralf in rust-lang#117763 (comment)
Copy link
Member

jhpratt commented Aug 21, 2025

@bors r- #145697 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2025
Copy link
Collaborator

rustbot commented Sep 21, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Member Author

the8472 commented Sep 21, 2025

  • added two more negative assertions for branchy IR
  • Fixed the 32bit issue

@bors r=Mark-Simulacrum

Copy link
Collaborator

bors commented Sep 21, 2025

📌 Commit 5f0a68e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2025
Copy link
Collaborator

bors commented Sep 21, 2025

⌛ Testing commit 5f0a68e with merge 6720f83...

bors added a commit that referenced this pull request Sep 21, 2025
Copy link
Collaborator

The job i686-gnu-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] rustc_ast_lowering test:false 115.172
 Compiling rustc_hir_typeck v0.0.0 (/checkout/compiler/rustc_hir_typeck)
[RUSTC-TIMING] rustc_passes test:false 122.240
 Compiling rustc_mir_transform v0.0.0 (/checkout/compiler/rustc_mir_transform)
rustc: /checkout/src/llvm-project/llvm/include/llvm/ADT/DenseMap.h:696: bool llvm::DenseMapBase<DerivedT, KeyT, ValueT, KeyInfoT, BucketT>::LookupBucketFor(const LookupKeyT&, BucketT*&) [with LookupKeyT = unsigned int; DerivedT = llvm::SmallDenseMap<unsigned int, unsigned int, 8, llvm::DenseMapInfo<unsigned int>, llvm::detail::DenseMapPair<unsigned int, unsigned int> >; KeyT = unsigned int; ValueT = unsigned int; KeyInfoT = llvm::DenseMapInfo<unsigned int>; BucketT = llvm::detail::DenseMapPair<unsigned int, unsigned int>]: Assertion `!KeyInfoT::isEqual(Val, EmptyKey) && !KeyInfoT::isEqual(Val, TombstoneKey) && "Empty/Tombstone value shouldn't be inserted into map!"' failed.
[RUSTC-TIMING] rustc_hir_analysis test:false 311.044
rustc exited with signal: 6 (SIGABRT) (core dumped)
error: could not compile `rustc_hir_analysis` (lib)
Caused by:
 process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/bootstrap/debug/rustc --crate-name rustc_hir_analysis --edition=2024 compiler/rustc_hir_analysis/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C debug-assertions=on --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values())' -C metadata=9d80dd9c41594c2a -C extra-filename=-075e4736f021738d --out-dir /checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps --target i686-unknown-linux-gnu -L dependency=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/release/deps --extern itertools=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/libitertools-dacaaa91fa8dcb84.rmeta --extern rustc_abi=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_abi-a1ad94673b75da00.rmeta --extern rustc_arena=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_arena-d91188f4bf2005c3.rmeta --extern rustc_ast=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_ast-8bfe4538be8ab4ea.rmeta --extern rustc_attr_parsing=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_attr_parsing-bd7420663e693bd2.rmeta --extern rustc_data_structures=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_data_structures-d497170800c79112.rmeta --extern rustc_errors=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_errors-5236e24ee0e4e0a8.rmeta --extern rustc_feature=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_feature-452be44ba5cd83be.rmeta --extern rustc_fluent_macro=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/release/deps/librustc_fluent_macro-0640e03536e8e0da.so --extern rustc_hir=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_hir-964d79bd75bc9c24.rmeta --extern rustc_index=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_index-e4d9a13f97a6cd9e.rmeta --extern rustc_infer=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_infer-a04c617f36506442.rmeta --extern rustc_lint_defs=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_lint_defs-923e9b83d0855ce1.rmeta --extern rustc_macros=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/release/deps/librustc_macros-73dcb59543757f8b.so --extern rustc_middle=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_middle-2b5adb7c8ef97ae4.rmeta --extern rustc_session=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_session-828f8eef4626a9fd.rmeta --extern rustc_span=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_span-0661bb275da0003a.rmeta --extern rustc_target=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_target-d09ff454cb38c722.rmeta --extern rustc_trait_selection=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/librustc_trait_selection-090786403b89c73c.rmeta --extern smallvec=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/libsmallvec-14323ad115676539.rmeta --extern tracing=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/deps/libtracing-d679846f73cb7168.rmeta --cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options '--check-cfg=cfg(bootstrap)' -Zmacro-backtrace -Csplit-debuginfo=off -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Alinker-messages -Zon-broken-pipe=kill -Z binary-dep-depinfo -L native=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/build/psm-4d4e01415bb22502/out -L native=/checkout/obj/build/i686-unknown-linux-gnu/stage2-rustc/i686-unknown-linux-gnu/release/build/blake3-086afc1e7ff03826/out` (exit status: 254)
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] rustc_borrowck test:false 347.272
[RUSTC-TIMING] rustc_mir_transform test:false 288.871
[RUSTC-TIMING] rustc_hir_typeck test:false 360.656
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`

Copy link
Collaborator

bors commented Sep 21, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2025
Copy link
Member Author

the8472 commented Sep 21, 2025

seems spurious, a codegen test can't make a rustc build fail.

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 22, 2025 
...ark-Simulacrum
regression test for Cow<[u8]> layout
requested by ralf in rust-lang#117763 (comment)
Copy link
Contributor

Yielding to enclosing rollup.

@bors retry

bors added a commit that referenced this pull request Sep 22, 2025 
Rollup of 10 pull requests
Successful merges:
 - #145411 (regression test for Cow<[u8]> layout)
 - #146317 (Add panic=immediate-abort)
 - #146397 (std_detect on Darwin AArch64: update features)
 - #146594 (bootstrap: Don't force -static for musl targets in cc-rs)
 - #146652 (Port `feature` to the new attribute system)
 - #146791 (emit attribute for readonly non-pure inline assembly)
 - #146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly)
 - #146838 (Introduce "wrapper" helpers to rustdoc)
 - #146846 (btree InternalNode::new safety comments)
 - #146858 (Make mips64el-unknown-linux-muslabi64 link dynamically)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 22, 2025
Copy link
Collaborator

bors commented Sep 22, 2025

⌛ Testing commit 5f0a68e with merge 00e5d01...

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 22, 2025 
...ark-Simulacrum
regression test for Cow<[u8]> layout
requested by ralf in rust-lang#117763 (comment)
Copy link
Contributor

Yielding to enclosing rollup.

@bors retry

bors added a commit that referenced this pull request Sep 22, 2025 
Rollup of 9 pull requests
Successful merges:
 - #145411 (regression test for Cow<[u8]> layout)
 - #146317 (Add panic=immediate-abort)
 - #146397 (std_detect on Darwin AArch64: update features)
 - #146594 (bootstrap: Don't force -static for musl targets in cc-rs)
 - #146791 (emit attribute for readonly non-pure inline assembly)
 - #146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly)
 - #146838 (Introduce "wrapper" helpers to rustdoc)
 - #146846 (btree InternalNode::new safety comments)
 - #146858 (Make mips64el-unknown-linux-muslabi64 link dynamically)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 22, 2025
Copy link
Collaborator

bors commented Sep 22, 2025

⌛ Testing commit 5f0a68e with merge 10d6de9...

Copy link
Contributor

@bors retry

bors added a commit that referenced this pull request Sep 22, 2025 
Rollup of 9 pull requests
Successful merges:
 - #145411 (regression test for Cow<[u8]> layout)
 - #146317 (Add panic=immediate-abort)
 - #146397 (std_detect on Darwin AArch64: update features)
 - #146594 (bootstrap: Don't force -static for musl targets in cc-rs)
 - #146791 (emit attribute for readonly non-pure inline assembly)
 - #146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly)
 - #146838 (Introduce "wrapper" helpers to rustdoc)
 - #146846 (btree InternalNode::new safety comments)
 - #146858 (Make mips64el-unknown-linux-muslabi64 link dynamically)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 22, 2025
Copy link
Collaborator

bors commented Sep 22, 2025

⌛ Testing commit 5f0a68e with merge 56a352f...

Copy link
Collaborator

bors commented Sep 22, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 22, 2025
Copy link
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
curl: (35) Recv failure: Connection was reset
curl: (35) Recv failure: Connection was reset
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 0:00:07
make: *** [Makefile:123: ci-mingw-x] Error 1
 local time: Mon Sep 22 09:33:08 CUT 2025
 network time: 2025年9月22日 09:33:08 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

Copy link
Contributor

@bors retry (flaky)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2025
bors added a commit that referenced this pull request Sep 22, 2025 
Rollup of 9 pull requests
Successful merges:
 - #145411 (regression test for Cow<[u8]> layout)
 - #146397 (std_detect on Darwin AArch64: update features)
 - #146791 (emit attribute for readonly non-pure inline assembly)
 - #146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly)
 - #146838 (Introduce "wrapper" helpers to rustdoc)
 - #146845 (Add self-profile events for target-machine creation)
 - #146846 (btree InternalNode::new safety comments)
 - #146858 (Make mips64el-unknown-linux-muslabi64 link dynamically)
 - #146878 (assert_unsafe_precondition: fix some incorrect check_language_ub)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8c0c537 into rust-lang:master Sep 22, 2025
10 of 11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 22, 2025
rust-timer added a commit that referenced this pull request Sep 22, 2025 
Rollup merge of #145411 - the8472:cows-have-no-branches, r=Mark-Simulacrum
regression test for Cow<[u8]> layout
requested by ralf in #117763 (comment)
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025 
...ark-Simulacrum
regression test for Cow<[u8]> layout
requested by ralf in rust-lang#117763 (comment)
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025 
Rollup of 9 pull requests
Successful merges:
 - rust-lang#145411 (regression test for Cow<[u8]> layout)
 - rust-lang#146397 (std_detect on Darwin AArch64: update features)
 - rust-lang#146791 (emit attribute for readonly non-pure inline assembly)
 - rust-lang#146831 (Support ctr and lr as clobber-only registers in PowerPC inline assembly)
 - rust-lang#146838 (Introduce "wrapper" helpers to rustdoc)
 - rust-lang#146845 (Add self-profile events for target-machine creation)
 - rust-lang#146846 (btree InternalNode::new safety comments)
 - rust-lang#146858 (Make mips64el-unknown-linux-muslabi64 link dynamically)
 - rust-lang#146878 (assert_unsafe_precondition: fix some incorrect check_language_ub)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /